Fix bufferedAmount not updating #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstoykov
requested review from
oleiade and
joanlopez
and removed request for
a team
joanlopez
approved these changes
May 23, 2024
5 tasks
oleiade
approved these changes
May 23, 2024
mstoykov
force-pushed
the
fixBufferedAmount
branch
from
17b1c39 to
1a0659a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix bufferedAmount being observable from js.
Why?
This is actually how it was supposed to work all along, but the code just exported the value at the time of creating the WebSocket.
It now also includes a test.
Checklist
make lint) and all checks pass.make test) and all tests pass.Related PR(s)/Issue(s)
Based on #68