Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop debugging stuff + other refactors #44

Merged
merged 4 commits into from
Apr 19, 2023
Merged

Drop debugging stuff + other refactors #44

merged 4 commits into from
Apr 19, 2023

Conversation

mstoykov
Copy link
Collaborator

No description provided.

This drops some code to help with debugging which likely should've never
been committed like this.
@mstoykov mstoykov requested a review from olegbespalov April 10, 2023 07:51
@mstoykov
Copy link
Collaborator Author

Did some cleanup of the code base.

Code reviewing per commit is a lot easier as I do move some stuff around a la xk6-grpc

Copy link
Contributor

@olegbespalov olegbespalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a non-blocking suggestion

websockets/websockets.go Outdated Show resolved Hide resolved
@mstoykov mstoykov force-pushed the dropDebuggingStuff branch from 01d2e22 to c98550d Compare April 19, 2023 09:18
@mstoykov mstoykov merged commit 652ea5c into main Apr 19, 2023
@mstoykov mstoykov deleted the dropDebuggingStuff branch April 19, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants