Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete k8s integration tests #340

Merged
merged 3 commits into from
Sep 13, 2023
Merged

Conversation

pablochacin
Copy link
Collaborator

@pablochacin pablochacin commented Sep 12, 2023

Description

Complete migration of kubernetes package tests to Testcontainers started with #323

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make test) and all tests pass.
  • I have run relevant integration test locally (make integration-xxx for agent or kubernetes related changes)
  • I have run relevant e2e test locally (make e2e-xxx for disruptors or cluster related changes)
  • Any dependent changes have been merged and published in downstream modules

Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
@pablochacin pablochacin marked this pull request as draft September 12, 2023 17:49
@pablochacin pablochacin force-pushed the complete-k8s-integration-tests branch 2 times, most recently from cc75a10 to f9a4484 Compare September 13, 2023 07:52
@pablochacin pablochacin marked this pull request as ready for review September 13, 2023 07:52
@pablochacin pablochacin marked this pull request as draft September 13, 2023 07:55
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
@pablochacin pablochacin marked this pull request as ready for review September 13, 2023 08:04
Copy link
Member

@roobre roobre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I understand it, this removes the integration tests that were migrated to the new framework in #323, and additionaly migrates Test_UnsupportedKubernetesVersion. LGTM.

@pablochacin pablochacin merged commit ce51386 into main Sep 13, 2023
6 checks passed
@pablochacin pablochacin deleted the complete-k8s-integration-tests branch September 13, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants