fixup! disruptors: error out if there are no targets

grafana · Aug 28, 2023 · 4a2435d · 4a2435d
1 parent 5bcd09b
commit 4a2435d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/pkg/disruptors/pod.go b/pkg/disruptors/pod.go
@@ -20,6 +20,8 @@ import (
 // DefaultTargetPort defines default target port if not specified in Fault
 const DefaultTargetPort = 80
 
+// ErrSelectorNoPods is returned by NewPodDisruptor when the selector passed to it does not match any pod in the
+// cluster.
 var ErrSelectorNoPods = errors.New("no pods found matching selector")
 
 // PodDisruptor defines the types of faults that can be injected in a Pod

diff --git a/pkg/disruptors/service.go b/pkg/disruptors/service.go
@@ -13,6 +13,7 @@ import (
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 )
 
+// ErrServiceNoTargets is returned by NewServiceDisruptor when passed a service without any pod matching its selector.
 var ErrServiceNoTargets = errors.New("service does not have any backing pods")
 
 // ServiceDisruptor defines operations for injecting faults in services