This repository was archived by the owner on Jan 30, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 43
Refactor parseBrowserContextOptions
to Sobek
#1526
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8a891d6
to
7d1388a
Compare
parseBrowserContextOptions
parseBrowserContextOptions
to Sobek
7e43386
to
eea70f6
Compare
3cd03ac
to
d72e163
Compare
ankur22
previously approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like a good idea, but I think we should add another test to ensure that all the fields are parsed/exported/merged as we expect.
b6806de
to
14d6082
Compare
Base automatically changed from
remove/network-manager-extra-http-headers
to
main
November 7, 2024 14:45
NewBrowserContextOptions no longer makes sense. DefaultBrowserContextOptions also reads better when we look at the code. We can easily tell we're working with the default options, not just a new BrowserContextOptions value.
e132b27
to
96a3172
Compare
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Refactor
parseBrowserContextOptions
to use direct Sobek transformation.Why?
After the refactorings we made in #1270, it's now possible to let Sobek perform this transformation alone.
Checklist
Script
I also used the script to test it using my old friend
Printf
inBrowser.NewContext
etc..Related PR(s)/Issue(s)
BrowserContext
methods #1270