This repository was archived by the owner on Jan 30, 2025. It is now read-only.
Fix the Geolocation.Accuracy field and adds a test
#1507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankur22
previously approved these changes
Nov 4, 2024
There was a problem hiding this comment.
Good find, and thanks for this fix!
This could be related to https://github.com/grafana/xk6-browser/issues/435 🤞
Fix the typo in the JSON tag.
inancgumus
force-pushed
the
fix/browser-context-geolocation-accuracy
branch
from
377221b to
2c627af
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix the
Geolocation.Accuracyfield typo and add a test to validate the issue.Why?
The test wasn't running without this fix. Also, users JSON serialization wouldn't work.
Checklist
Related PR(s)/Issue(s)
BrowserContextmethods #1504geolocationoption fornewContexton theBrowserclass doesn't seem to override the real geolocation k6#4437