Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the Geolocation.Accuracy field and adds a test #1507

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Fix the Geolocation.Accuracy field and adds a test #1507

merged 2 commits into from
Nov 5, 2024

Conversation

inancgumus
Copy link
Member

@inancgumus inancgumus commented Nov 4, 2024 •
edited
Loading

What?

Fix the Geolocation.Accuracy field typo and add a test to validate the issue.

Why?

The test wasn't running without this fix. Also, users JSON serialization wouldn't work.

Checklist

  • I have performed a self-review of my code
  • I have added tests for my changes
  • I have commented on my code, particularly in hard-to-understand areas

Related PR(s)/Issue(s)

@inancgumus inancgumus added the bug Something isn't working label Nov 4, 2024
@inancgumus inancgumus self-assigned this Nov 4, 2024
@inancgumus inancgumus mentioned this pull request Nov 4, 2024
Closed
@inancgumus inancgumus marked this pull request as ready for review November 4, 2024 16:05
@inancgumus inancgumus requested a review from ankur22 November 4, 2024 16:05
ankur22
ankur22 previously approved these changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find, and thanks for this fix!

This could be related to #435 🤞

Base automatically changed from desobekify/browser-context to main November 5, 2024 17:28
@inancgumus inancgumus dismissed ankur22’s stale review November 5, 2024 17:28

The base branch was changed.

@inancgumus inancgumus force-pushed the fix/browser-context-geolocation-accuracy branch from 377221b to 2c627af Compare November 5, 2024 17:29
@inancgumus inancgumus merged commit 2303d9c into main Nov 5, 2024
22 of 23 checks passed
@inancgumus inancgumus deleted the fix/browser-context-geolocation-accuracy branch November 5, 2024 17:33
@BrewTestBot BrewTestBot mentioned this pull request Jan 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankur22 ankur22 ankur22 left review comments

Assignees

@inancgumus inancgumus

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inancgumus @ankur22