Fix page goto tests for async

#1312 (comment)
grafana · May 8, 2024 · 5cdfa61 · 5cdfa61
1 parent 099a6a4
commit 5cdfa61
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/tests/browser_context_test.go b/tests/browser_context_test.go
@@ -659,7 +659,7 @@ func TestK6Object(t *testing.T) {
 			got, err := vu.TestRT.RunOnEventLoop(`
 				(async function() {
 					const p = await browser.newPage();
-					p.goto("about:blank");
+					await p.goto("about:blank");
 					const o = p.evaluate(() => window.k6);
 					return JSON.stringify(o);
 				})();
@@ -675,7 +675,7 @@ func TestK6Object(t *testing.T) {
 					await browser.closeContext();
 					const c = await browser.newContext();
 					const p2 = await c.newPage();
-					p2.goto("about:blank");
+					await p2.goto("about:blank");
 					const o2 = p2.evaluate(() => window.k6);
 					return JSON.stringify(o2);
 				})();
@@ -714,10 +714,10 @@ func TestNewTab(t *testing.T) {
 	_, err := vu.TestRT.RunOnEventLoop(fmt.Sprintf(`
 		(async function() {
 			const p = await browser.newPage()
-			p.goto("%s/%s/ping.html")
+			await p.goto("%s/%s/ping.html")
 
 			const p2 = browser.context().newPage()
-			p2.goto("%s/%s/ping.html")
+			await p2.goto("%s/%s/ping.html")
 		})()`, s.URL, testBrowserStaticDir, s.URL, testBrowserStaticDir))
 	require.NoError(t, err)
 }