Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up CI linting #819

Merged
merged 3 commits into from
Jul 15, 2021
Merged

Clean up CI linting #819

merged 3 commits into from
Jul 15, 2021

Conversation

yvrhdn
Copy link
Member

@yvrhdn yvrhdn commented Jul 15, 2021

What this PR does:
Attempt to tweak golangci-lint and its linters to avoid CI failing on unrelated issues (as happened in #808).

@yvrhdn yvrhdn changed the title Tweak golangci-lint: exclude Log statements from errcheck Clean up CI linting Jul 15, 2021
@yvrhdn yvrhdn marked this pull request as ready for review July 15, 2021 18:20
@yvrhdn
Copy link
Member Author

yvrhdn commented Jul 15, 2021

I can confirm the changes from #808 pass with the new config, see #820 🙂

@joe-elliott joe-elliott merged commit c1ca1e0 into grafana:main Jul 15, 2021
@yvrhdn yvrhdn deleted the golangci-lint branch July 15, 2021 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants