Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break the compaction loop if context is cancelled #4476

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

joe-elliott
Copy link
Member

What this PR does:

In this PR we improved the compactors to drop out of a job if it lost ownership. We also introduced a bug where, during shutdown, the code would spin endlessly in a tight loop. This impacts the single binary mode significantly more than the distributed mode where compactors shut down very quickly. Also removed an unused ticker.

Thanks to @Wessie for finding the issue.

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott joe-elliott merged commit 0aecee5 into grafana:main Dec 19, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants