[TraceQL Metrics] histogram_over_time #3644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of metrics and hints
… end. Refactor label handling to be shared. Validate quantiles, support quantile_over_time by any integer attribute
…conditions on the same attribute
…oss blocks, and across generators. Error handling, move code around
…le_over_time test, code cleanup
…log2, for several reasons: support non-log2 or native histogram buckets in the future, and where queriers on different versions may have different buckets during rollout
mdisibio
changed the title
mdisibio
requested review from
annanay25,
mapno,
yvrhdn,
zalegrala,
electron0zero,
ie-pham and
stoewer
as code owners
mdisibio
changed the title
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds
histogram_over_time, requires merging #3633 first. This function supports the creation of heatmaps. Implementation and data flow is similar to quantiles but we preserve the bucket counts at the end. Internally it's executing a query{ } | count_over_time() by (log2(<field>)), but making it a new top-level function is straight-forward and more readable. Maybe long-term we do expand the language to allow grouping by a field expression (func(.foo)) instead of just attributes (.foo)Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]