Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tempo: Refactor Trace By ID and Metrics Summary #3522

Merged
merged 22 commits into from
Apr 11, 2024
Merged

Tempo: Refactor Trace By ID and Metrics Summary #3522

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
638c263
extend buildUpstreamRequest
joe-elliott Mar 12, 2024
5bf1ae0
metrics summary
joe-elliott Mar 25, 2024
31e1c77
trace by id first pass
joe-elliott Mar 26, 2024
440d8af
fixed inf loop
joe-elliott Mar 26, 2024
6ce0c4b
works
joe-elliott Mar 26, 2024
741b93e
removed trace id hedging in the frontend
joe-elliott Mar 26, 2024
33f2830
todos, tests and cleanup
joe-elliott Mar 26, 2024
d33271e
add 429 test
joe-elliott Mar 26, 2024
5dff65d
changelog
joe-elliott Mar 26, 2024
5c758eb
lint
joe-elliott Mar 27, 2024
ff22035
restore api prefix
joe-elliott Mar 27, 2024
f39d824
pass the right param
joe-elliott Mar 27, 2024
74b843b
fix race in test
joe-elliott Mar 27, 2024
2b2310e
Merge branch 'main' into refactor-final-endpoints
joe-elliott Mar 28, 2024
ad57206
move deduper into combiner
joe-elliott Apr 6, 2024
a5bfcb6
Move content type marshalling into combiner
joe-elliott Apr 6, 2024
998f635
Merge branch 'main' into refactor-final-endpoints
joe-elliott Apr 7, 2024
1d53ed8
lint: check err in test
joe-elliott Apr 7, 2024
6445fde
Update integration/e2e/limits_test.go
joe-elliott Apr 11, 2024
3053b1f
Apply suggestions from code review
joe-elliott Apr 11, 2024
62d6fe2
rename func for clarity
joe-elliott Apr 11, 2024
3e1ce06
review
joe-elliott Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update integration/e2e/limits_test.go 
Co-authored-by: Koenraad Verheyden <koenraad.verheyden@posteo.net>
  • Loading branch information
@joe-elliott @yvrhdn
joe-elliott and yvrhdn authored Apr 11, 2024
commit 6445fde66511e76f6f3399eee80cbe35ab994e17
2 changes: 1 addition & 1 deletion integration/e2e/limits_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ func TestQueryRateLimits(t *testing.T) {
callFlush(t, tempo)
time.Sleep(2 * time.Second) // trace idle and flush time are both 1ms
}
// now try to query it back. this should fail b/c the trace is too large
// now try to query it back. this should fail b/c the frontend queue doesn't have room
client := httpclient.New("http://"+tempo.Endpoint(3200), tempoUtil.FakeTenantID)

// 429 HTTP Trace ID Lookup
Expand Down
Loading