Skip to content

Commit

Permalink
Jsonnet: always use append (+:) when extending config (#784)
Browse files Browse the repository at this point in the history
By not appending new config, the jsonnet library might overwrite custom user configuration. We should favour appending whenever extending an already existing object (in this case $.tempo_config).
  • Loading branch information
yvrhdn authored Jun 21, 2021
1 parent 8783474 commit 0949d52
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions operations/jsonnet/microservices/configmap.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -51,21 +51,21 @@
},

tempo_distributor_config:: $.tempo_config {
distributor: {
distributor+: {
receivers: $._config.distributor.receivers,
},
},

tempo_ingester_config:: $.tempo_config{},

tempo_compactor_config:: $.tempo_config {
compactor: {
compaction: {
compactor+: {
compaction+: {
chunk_size_bytes: 10485760,
block_retention: '144h',
},
ring: {
kvstore: {
ring+: {
kvstore+: {
store: 'memberlist',
},
},
Expand Down

0 comments on commit 0949d52

Please sign in to comment.