Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extract: Don't crash when the error is not an ErrorPrimitiveReached #967

Merged
merged 2 commits into from
Dec 19, 2023
Merged

extract: Don't crash when the error is not an ErrorPrimitiveReached #967

merged 2 commits into from
Dec 19, 2023

Commits on Dec 5, 2023

  1. export: Add test to check that invalid Kubernetes manifests produce a… 

    … proper error

Currently fails, to be fixed in the next commit
    @iainlane
    iainlane committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    9f21bbe View commit details
    Browse the repository at this point in the history

  2. extract: Don't crash when the error is not an ErrorPrimitiveReached 

    When there's an invalid Kubernetes object, we can get a
`*manifest.SchemaError` here, for example. We currently panic, but
instead we should return the error so it can be displayed properly.
    @iainlane
    iainlane committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    8867d7e View commit details
    Browse the repository at this point in the history