fix: make export --format respect "/" in template actions #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dewe
force-pushed
the
fix_export_format_path_replace
branch
from
2995ed5
to
a748657
Compare
During tk export path separators are temporarily replaced with BEL in
order to protect paths from being mixed with template output. But when
there is a slash in a template action (e.g. {{index .metadata.labels
"app.kubernetes.io/name"}}, that slash also got replaced, and the
template did not work as expected.
This fix ensures that the BEL replacement only occurs within the text
portions of the template, and the action blocks are being preserved.
Fixes grafana#568
dewe
force-pushed
the
fix_export_format_path_replace
branch
from
a748657
to
55e9359
Compare
Duologic
approved these changes
Jul 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During
tk exportpath separators are temporarily replaced withBELchar in order to protect paths from being mixed with template output. But when there is a slash in a template action (e.g.{{index .metadata.labels "app.kubernetes.io/name"}}, that slash also got replaced, and the template did not work as expected.This fix ensures that the BEL replacement only occurs within the text portions of the template, and the action blocks are being preserved.
Fixes #568