feat: s/ksonnet-lib/k8s-alpha #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duologic
force-pushed
the
duologic/init_k8s-alpha
branch
from
de9ae1c
to
ee2b4fc
Compare
|
force push for rewording a commit message. |
Duologic
commented
May 20, 2021
| }, | ||
| }, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Formatting due to jsonnet-fmt run by my IDE.
malcolmholmes
approved these changes
May 20, 2021
Co-authored-by: malcolmholmes <42545407+malcolmholmes@users.noreply.github.com>
Duologic
commented
May 21, 2021
malcolmholmes
approved these changes
May 25, 2021
| @@ -22,8 +25,7 @@ func initCmd() *cli.Command { | |||
| } | |||
|
|
|||
| force := cmd.Flags().BoolP("force", "f", false, "ignore the working directory not being empty") | |||
| installK8sLibFlag := cmd.Flags().Bool("k8s", true, "set to false to skip installation of k8s-alpha") | |||
| installK8sVersion := cmd.Flags().String("k8sversion", "1.20", "choose the version of k8s-alpha") | |||
| installK8s := cmd.Flags().String("k8s", defaultK8sVersion, "choose the version of k8s-alpha, set to false to skip") | |||
There was a problem hiding this comment.
no shorthand version?
There was a problem hiding this comment.
Would that be better? This approach keeps compatibility with --k8s=<bool> flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to propose making k8s-alpha the default library we refer to
instead of the long ago abandoned ksonnet-lib.
Grafana Labs has been using
k8s-alphasince its inception by @sh0rez over a year ago this month. Theksonnet-util has since been refactored and provides
an adequate compatibility layer to make the transition seamless.
This PR updates the
tk initcommand to initiate a Tanka directory structure using thek8s-alphalibrary and replacesmost if not all
ksonnet-libreferences withk8s-alphain the docs. I also sneaked in a few Jsonnet best practices,not stacking Jsonnet libraries on the root.