perf(export): only call FindEnvs once #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sh0rez
requested changes
Apr 12, 2021
| @@ -92,6 +80,7 @@ type parallelOut struct { | |||
|
|
|||
| func parallelWorker(jobsCh <-chan parallelJob, outCh chan parallelOut) { | |||
| for job := range jobsCh { | |||
| log.Printf("Loading %s from %s", job.opts.Name, job.path) | |||
There was a problem hiding this comment.
Supposed to be here? Sounds quite verbose imo
There was a problem hiding this comment.
I left it intentionally. It gives a bit of feedback to the user as opposed to no feedback right now. I'm happy to remove or accept other suggestions to give a sense of progress.
There was a problem hiding this comment.
Fair enough. I'm not totally familiar, does this codepath affect any other actions than export?
sh0rez
approved these changes
Apr 12, 2021
| @@ -92,6 +80,7 @@ type parallelOut struct { | |||
|
|
|||
| func parallelWorker(jobsCh <-chan parallelJob, outCh chan parallelOut) { | |||
| for job := range jobsCh { | |||
| log.Printf("Loading %s from %s", job.opts.Name, job.path) | |||
There was a problem hiding this comment.
Fair enough. I'm not totally familiar, does this codepath affect any other actions than export?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the internal Grafana Labs jsonnet code base, this can improve the performance of the export significantly. Tests on my local
machine went from 2m08s to 1m32s.