feat: add metadata.Namespace #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duologic
force-pushed
the
duologic/metdata_path
branch
from
52d57cb
to
1a17546
Compare
Duologic
force-pushed
the
duologic/metdata_path
branch
from
1a17546
to
6d50338
Compare
sh0rez
approved these changes
Dec 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets
metadata.Namespaceat runtime, the path relative to the root. This removes the assumption that name equalspath and also shows up in tk env list --json, which can in turn be used by other tools that want to perform bulk actions
on Tanka environments.
Pulled out of #433 as I think this is useful in the context of inline environments while the pruneMark is way more
controversial.