fix(helm): Check prior vendoring of helm charts #402
Conversation
| @@ -199,3 +206,14 @@ func parseReq(s string) (*Requirement, error) { | |||
| Version: *ver, | |||
| }, nil | |||
| } | |||
|
|
|||
| // parseReqName parses a name from a string of the format `repo/name` or `name` | |||
| func parseReqName(s string) string { | |||
There was a problem hiding this comment.
It seems like parseReqName is only ever called with an argument of the form name@repo as r.Chart looks like this.
Any reason this function also handles plain name?
There was a problem hiding this comment.
I'm just being defensive in the case a chart name didn't have a repo/ prefix, I'm not sure how the helm community does it across the board.
There was a problem hiding this comment.
@sh0rez Does that make sense? I'm happy to simplify it if that case won't happen. Just let me know.
There was a problem hiding this comment.
The use of repo/name promotes making a clear distinction which Chart one refers to, I would be in favor of enforcing this.
There was a problem hiding this comment.
Gotcha. I removed the check.
justinwalz
force-pushed
the
fix/helm-chart-vendor
branch
from
b144399
to
a8a9594
Compare
Fixes #401