feat(cli): Charttool #367
Merged
feat(cli): Charttool #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renames the helmraiser package to helm, because its scope is going to be extended in the following. It will not only cover helmraiser functionality going on, but also house declarative chart management code
Adds a new `tk tool charts` command, which enables declarative management of vendored Helm charts. As proposed by https://docs.google.com/document/d/171F0cm_VliMStmHe6oy5pAbuXihr-7Cb5yD-vmwqpP8, Helm Charts should be vendored by the individual library that consumes them. To simplify this process, `tk tool charts` provides a declarative config file to automate `helm pull`. The rest of above document will be implemented in subsequent pull requests
sh0rez
added
kind/feature
wtf happened here
malcolmholmes
approved these changes
Sep 1, 2020
| return err | ||
| } | ||
|
|
||
| fmt.Print(string(data)) |
There was a problem hiding this comment.
could we colourise this?
There was a problem hiding this comment.
Not easily. The only yaml highlighter library I am aware of (alecthomas/chroma) doesn't handle yaml well, especially not on light schemed terminals.
We actually removed it from the project for that exact reason some time ago (were coloring diff using it)
We could look into writing a custom yaml highlighter some day
| Version: Version, | ||
| Repositories: []Repo{{ | ||
| Name: "stable", | ||
| URL: "https://kubernetes-charts.storage.googleapis.com", |
There was a problem hiding this comment.
do we want this? Being deprecated soon?
There was a problem hiding this comment.
Currently it's the primary source of truth. Soon is not yet deprecated :)
We will remove as soon as deprecated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
tk tool chartscommand, which enables declarativemanagement of vendored Helm charts.
As proposed by
https://docs.google.com/document/d/171F0cm_VliMStmHe6oy5pAbuXihr-7Cb5yD-vmwqpP8,
Helm Charts should be vendored by the individual library that consumes
them.
To simplify this process,
tk tool chartsprovides a declarative configfile to automate
helm pull.The rest of above document will be implemented in subsequent pull requests