Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(helmraiser): Abstract template code #363
refactor(helmraiser): Abstract template code #363
Changes from 1 commit
501e6d8
a0e8c4e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could all be wrapped in the Helm.run() function, I would even think of returning
func (c *Cmd) Output() ([]byte, error)
for this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(bit awkward that github diff included the normalizeName, just ignore that)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reusing the same pattern that proved working well in
pkg/kubernetes/client
:tanka/pkg/kubernetes/client/exec.go
Line 21 in 3ff6c70
Returning the raw
exec.Cmd
allows consuming functions to also modify the commands environment, stdin, capture stderr if required, etc.I think we will need this in the future here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this replaces
parseYamlToMap
, could you move it into a function and add a unit test for it?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imo the implementation of yaml unmarshalling doesn't require testing here, because go-yaml is heavily unit tested itself, and unmarshalling yaml output into a
map[string]interface{}
pretty standard Go stuff.What I instead would like to test here is that the output of
helm
correctly ends up in Jsonnet, regardless of our actual Go implementation.I will add such a test in a subsequent pull request, which this one is the preparation for.