Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using jbBinary variable instead of hardcoded jb #350

Merged
merged 1 commit into from
Aug 20, 2020
Merged

Using jbBinary variable instead of hardcoded jb #350

merged 1 commit into from
Aug 20, 2020

Conversation

freddd
Copy link
Contributor

@freddd freddd commented Aug 20, 2020

A new environmental variable was added called TANKA_JB_PATH however it's not actually being used to install the packages due to "jb" still being hardcoded.

Copy link
Member

@sh0rez sh0rez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, awesome catch!

@sh0rez sh0rez merged commit 90774b1 into grafana:master Aug 20, 2020
@freddd
Copy link
Contributor Author

freddd commented Aug 21, 2020

Thanks for merging @sh0rez - when can we expect it to be released? It's currently blocking us :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants