Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #329: Windows indefinite loop #331

Merged
merged 6 commits into from
Aug 18, 2020
Merged

Fix issue #329: Windows indefinite loop #331

merged 6 commits into from
Aug 18, 2020

Conversation

c0ffeec0der
Copy link
Contributor

@c0ffeec0der c0ffeec0der commented Aug 7, 2020 •
edited by sh0rez
Loading

Problem: Indefinite loop in function findRoot

Root cause: Root path only consider linux "/"

Solution: Detect os at runtime and decide root path. Windows "C:\", others "/"

Fixes #329

c0feec0der and others added 4 commits August 7, 2020 10:47
Fix issue #329
b86c5d4 
Problem: Indefinite loop in function findRoot

Root cause: Root path only consider linux "/"

Solution: Detect os at runtime and decide root path. Windows "C:\\", others "/"
@c0ffeec0der
Fix issue #329
a935693 
Problem: Indefinite loop in function findRoot

Root cause: Root path only consider linux "/"

Solution: Detect os at runtime and decide root path. Windows "C:\\", others "/"
Fix issue #329
ee2a200 
Problem: Indefinite loop in function findRoot

Root cause: Root path only consider linux "/"

Solution: Detect os at runtime and decide root path. Windows "C:\\", others "/"
Fix issue #329
8300f91 
Problem: Indefinite loop in function findRoot

Root cause: Root path only consider linux "/"

Solution: Detect os at runtime and decide root path. Windows "C:\\", others "/"
@malcolmholmes
Copy link
Contributor

This makes the assumption that tanka files are on drive C:, is there another way to do it?

Fix issue #329
adadd5b 
Problem: Indefinite loop in function findRoot

Root cause: Root path only consider linux "/"

Solution: Detect os at runtime and decide root path. Windows "C:\\", others "/"
@c0ffeec0der
Copy link
Contributor Author

Ah yes, good one! Code updated with filepath.VolumeName

sh0rez
sh0rez requested changes Aug 11, 2020
View reviewed changes
Copy link
Member

@sh0rez sh0rez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

pkg/jsonnet/jpath/jpath.go Outdated Show resolved Hide resolved
@c0ffeec0der
Copy link
Contributor Author

Hello,

Is there still anything required for this PR to be merged?

Thank you

@sh0rez sh0rez merged commit 0070379 into grafana:master Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sh0rez sh0rez sh0rez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows: Tanka not running on windows
3 participants
@c0ffeec0der @malcolmholmes @sh0rez