Don't attach namespaces to non-namespaced resources #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sh0rez
requested changes
Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick and dirty way to NOT add namespaces to non-namespaced resource types like ClusterRoles or StorageClasses.
I ran into this when trying to export resources to a folder per namespace, and seeing things like ClusterRoles show up in nested namespaces, which is incorrect. It masked issues like multiple environments defining the same object because of the way it did this.
I implemented it as a simple list in namespace.go. If new types are added to the api we can add them here. It requires a little maintenance potentially, but it isn't world ending if we take too long to add something.