Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Order keys in walkObj #307

Merged
merged 1 commit into from
Jun 30, 2020
Merged

Order keys in walkObj #307

merged 1 commit into from
Jun 30, 2020

Conversation

jdbaldry
Copy link
Member

Improves user experience of errors where walking the JSON reaches a primitive that is not a Kubernetes object.

@jdbaldry jdbaldry requested a review from sh0rez June 30, 2020 20:49
@jdbaldry jdbaldry mentioned this pull request Jun 30, 2020
Closed
sh0rez
sh0rez approved these changes Jun 30, 2020
View reviewed changes
Copy link
Member

@sh0rez sh0rez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Not quite sure if we can write a proper test for this in Go, as map orders are not preserved. However, as this is fairly niche anyways, it should be fine like so

@sh0rez sh0rez merged commit 247e2be into master Jun 30, 2020
@sh0rez sh0rez deleted the ordered-process branch June 30, 2020 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sh0rez sh0rez sh0rez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdbaldry @sh0rez