Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(spec): Default apiServer URL to https #289

Merged
merged 1 commit into from
Jun 30, 2020
Merged

fix(spec): Default apiServer URL to https #289

merged 1 commit into from
Jun 30, 2020

Conversation

sh0rez
Copy link
Member

@sh0rez sh0rez commented Jun 9, 2020 •
edited
Loading

Defaults the apiServer URL scheme to https:// if unset.

Also fixes the message printed by tk init to include the scheme

Fixes #287

@sh0rez
fix(spec): Default apiServer URL to https
9f07d0f 
Defaults the apiServer URL scheme to `https://` if unset.

Also fixes the message printed by `tk init` to include the scheme
@sh0rez sh0rez added the kind/enhancement Improve something existing label Jun 9, 2020
@sh0rez sh0rez requested a review from captncraig June 25, 2020 19:44
jdbaldry
jdbaldry approved these changes Jun 30, 2020
View reviewed changes
Copy link
Member

@jdbaldry jdbaldry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@sh0rez sh0rez merged commit a61d852 into master Jun 30, 2020
@sh0rez sh0rez deleted the spec-proto branch June 30, 2020 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdbaldry jdbaldry jdbaldry approved these changes

@malcolmholmes malcolmholmes Awaiting requested review from malcolmholmes

@captncraig captncraig Awaiting requested review from captncraig

Assignees
No one assigned
Labels
kind/enhancement Improve something existing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tk init does not include protocol in spec.apiServer
2 participants
@sh0rez @jdbaldry