fix(diff): refuse to diff on kubectl 1.18 #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kubectl 1.18 includes an unfixed issue that causes diff to apply as well – which is a very bad thing. To avoid this, we now check and abort on that specific version, prompting the user to downgrade as no fix is yet available. kubernetes/kubernetes#89762
captncraig
reviewed
Apr 7, 2020
captncraig
approved these changes
Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kubectl 1.18 includes an unfixed issue that causes diff to apply as well – which
is a very bad thing. To avoid this, we now check and abort on that specific
version, prompting the user to downgrade as no fix is yet available.
kubernetes/kubernetes#89762