Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow environment vendor overrides #185

Merged
merged 3 commits into from
Jan 27, 2020
Merged

Conversation

slim-bean
Copy link
Contributor

Look for a vendor folder in the environment which will let you jb install a dep into the environment to override what's in the main project vendor folder

@slim-bean slim-bean requested a review from sh0rez January 24, 2020 03:41
@cyriltovena
Copy link

Ho wow, I needed this for one loki cluster.

@slim-bean
Copy link
Contributor Author

slim-bean commented Jan 24, 2020

I'm not sure if I'm making a mistake with the change to find the root jsonnet file by skipping up a directory. I think this is ok as I don't think it's valid for a flat structure? (unless i'm misisng a use case/requirement). That is to say, there will always be a root jsonnet.json file and then an environments folder below containing the environments with main.jsonnet?

@slim-bean slim-bean force-pushed the allow-environment-vendor-overrides branch from f8c1379 to ba7841c Compare January 25, 2020 21:08
@slim-bean
Copy link
Contributor Author

After some discussion with @sh0rez we backed out most of the original changes to this PR and instead are just adding a check for a local vendor folder in the base dir of the environment.

You won't be able to use jb currently to add environment specific overrides but you can use wget to add anything you want overridden.

@sh0rez sh0rez force-pushed the allow-environment-vendor-overrides branch from ba7841c to b019023 Compare January 27, 2020 17:54
@sh0rez sh0rez added component/jsonnet Everything regarding the jsonnet language kind/feature Something new should be added labels Jan 27, 2020
@sh0rez sh0rez force-pushed the allow-environment-vendor-overrides branch from b019023 to 25535cd Compare January 27, 2020 19:53
Copy link
Member

@sh0rez sh0rez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for Ed's parts

Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@sh0rez sh0rez merged commit 363d02c into master Jan 27, 2020
@sh0rez sh0rez deleted the allow-environment-vendor-overrides branch January 27, 2020 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/jsonnet Everything regarding the jsonnet language kind/feature Something new should be added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants