Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): server from context on env add #184

Merged
merged 2 commits into from
Jan 23, 2020
Merged

fix(cli): server from context on env add #184

merged 2 commits into from
Jan 23, 2020

Conversation

sh0rez
Copy link
Member

@sh0rez sh0rez commented Jan 23, 2020

Fixes #183

@sh0rez sh0rez added kind/bug Something isn't working component/cli Command Line Interface labels Jan 23, 2020
malcolmholmes
malcolmholmes approved these changes Jan 23, 2020
View reviewed changes
Copy link
Contributor

@malcolmholmes malcolmholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

I tried copying that bit of code, but it seems I put it in the wrong place. Thanks!

@sh0rez sh0rez merged commit 94ebc1a into master Jan 23, 2020
@sh0rez sh0rez deleted the env-add-context branch January 23, 2020 15:57
@sh0rez sh0rez mentioned this pull request Feb 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malcolmholmes malcolmholmes malcolmholmes approved these changes

Assignees
No one assigned
Labels
component/cli Command Line Interface kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tk env add doesn't honour server-from-context correctly
2 participants
@sh0rez @malcolmholmes