feat(kubernetes): subset-diff #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far, diffing was offloaded to kubectl. While this produces very nice results, it is only possible for kubernetes version 1.13+. Nevertheless, there are older cluster versions around, so these need to be supported as well. subset-diff addresses those cases in the hopefully best way possible. To reduce field bloat, it only diffes those fields, that are present in the local config. Kubernetes adds dynamic fields on the fly which we cannot know about, so this is required. Note: You WILL NOT see removed fields in the diff output. Upgrade your cluster version to 1.13+ and use native diffing.
tombrk
added
kind/feature
tomwilkie
reviewed
Aug 7, 2019
tomwilkie
reviewed
Aug 7, 2019
tomwilkie
approved these changes
Aug 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, diffing was offloaded to kubectl. While this produces very nice results,
it is only possible for kubernetes version 1.13+.
Nevertheless, there are older cluster versions around, so these need to be
supported as well. subset-diff addresses those cases in the hopefully best way
possible.
To reduce field bloat, it only diffes those fields, that are present in the
local config. Kubernetes adds dynamic fields on the fly which we cannot know
about, so this is required.
Note: You WILL NOT see removed fields in the diff output. Upgrade your cluster
version to 1.13+ and use native diffing.