docs: rework tutorial to not use global $ #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
zerok
reviewed
Jun 3, 2024
Co-authored-by: Horst Gutmann <horst.gutmann@grafana.com>
|
Cool! i'll find some time to rerun through the content again, probably reword a couple of things and then open it up for review |
zerok
approved these changes
Jun 10, 2024
Co-authored-by: Horst Gutmann <horst.gutmann@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still wip, i need to go through the content again.
I changed the "parameters" page to use functions and function parameters instead of a global config object, and reworked the following sections. I've also added a section at the end describing how to use a local config object to avoid some repetition but without the issues associated with having it as a global.
Fixes #816