fix: prevent concurrent writes in env list command

grafana · Oct 4, 2024 · ff92951 · ff92951
1 parent c5180bf
commit ff92951
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/pkg/tanka/find.go b/pkg/tanka/find.go
@@ -127,9 +127,13 @@ func findEnvsFromJsonnetFiles(jsonnetFiles []string, opts FindOpts) ([]*v1alpha1
 
 	for i := 0; i < opts.Parallelism; i++ {
 		go func() {
+			// We need to create a copy of the opts for each goroutine because
+			// the content may be modified down the line:
+			jsonnetOpts := opts.JsonnetOpts.Clone()
+
 			for jsonnetFile := range jsonnetFilesChan {
 				// try if this has envs
-				list, err := List(jsonnetFile, Opts{JsonnetOpts: opts.JsonnetOpts})
+				list, err := List(jsonnetFile, Opts{JsonnetOpts: jsonnetOpts})
 				if err != nil &&
 					// expected when looking for environments
 					!errors.As(err, &jpath.ErrorNoBase{}) &&