Skip to content

Commit

Permalink
Github pages: PR path fix (#794)
Browse files Browse the repository at this point in the history
When DNS is setup in Github pages, the URLs (ex: https://grafana.github.io/tanka/pr-preview/pr-783/) now always redirect to the tanka.dev DNS name
So it becomes: https://tanka.dev/pr-preview/pr-783/
Therefore, the path prefix is now wrong

Everything else is now running fine without Netlify!
  • Loading branch information
julienduchesne authored Dec 6, 2022
1 parent 0ddba90 commit 8016ce4
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/publish-page.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ jobs:
working-directory: docs
env:
# Main: https://tanka.dev/
# PRs: https://grafana.github.io/tanka/pr-preview/pr-{number}/
PATH_PREFIX: "${{ github.event_name == 'pull_request' && format('/tanka/pr-preview/pr-{0}', github.event.number) || '' }}"
# PRs: https://tanka.dev/pr-preview/pr-{number}/
PATH_PREFIX: "${{ github.event_name == 'pull_request' && format('/pr-preview/pr-{0}', github.event.number) || '' }}"
run: |
yarn install
yarn build
Expand Down

0 comments on commit 8016ce4

Please sign in to comment.