Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lib): add pyroscope logo #851

Merged
merged 6 commits into from
Feb 15, 2022
Merged

chore(lib): add pyroscope logo #851

merged 6 commits into from
Feb 15, 2022

Conversation

eh-am
Copy link
Collaborator

@eh-am eh-am commented Feb 15, 2022

image

Add a simple logo to the exported component.

We should require something like
https://support.algolia.com/hc/en-us/articles/4406981826065-Do-I-need-to-display-the-Algolia-logo-when-on-a-free-plan-
so that people don't just hide using CSS.

Also @Rperry2174 will probably come up with a better design for this.

@eh-am eh-am force-pushed the chore/add-pyroscope-logo branch from 5210abb to 53199c7 Compare February 15, 2022 13:41
@github-actions
Copy link
Contributor

github-actions bot commented Feb 15, 2022

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 365.69 KB (+0.06% 🔺) 7.4 s (+0.06% 🔺) 1.2 s (-18.34% 🔽) 8.5 s

@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #851 (ea887e6) into main (7aee880) will decrease coverage by 3.39%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #851      +/-   ##
==========================================
- Coverage   70.44%   67.05%   -3.38%     
==========================================
  Files          71       81      +10     
  Lines        2523     2837     +314     
  Branches      458      544      +86     
==========================================
+ Hits         1777     1902     +125     
- Misses        718      907     +189     
  Partials       28       28              
Impacted Files Coverage Δ
...nents/FlameGraph/FlameGraphComponent/Flamegraph.ts 93.79% <ø> (+0.04%) ⬆️
...omponents/FlameGraph/FlamegraphRenderer.module.css 61.54% <0.00%> (ø)
...cript/components/FlameGraph/FlameGraphRenderer.jsx 45.54% <100.00%> (ø)
webapp/lib/index.tsx 100.00% <100.00%> (ø)
...FlameGraph/FlameGraphComponent/Tooltip.module.scss 61.54% <0.00%> (ø)
webapp/images/logo-v3-small.svg 100.00% <0.00%> (ø)
...ebapp/javascript/components/ExportData.module.scss 61.54% <0.00%> (ø)
.../FlameGraph/FlameGraphComponent/styles.module.scss 61.54% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a822ae6...ea887e6. Read the comment docs.

@eh-am eh-am marked this pull request as ready for review February 15, 2022 14:08
@pyroscopebot
Copy link
Collaborator

pyroscopebot commented Feb 15, 2022

Screenshots

Throughput Throughput
Disk Usage Disk Usage
Memory Memory
Upload Errors (Total) Upload Errors (Total)
Successful Uploads (Total) Successful Uploads (Total)
CPU Utilization CPU Utilization

Generated by 🚫 dangerJS against f8c5f5b

@eh-am eh-am merged commit e160a68 into main Feb 15, 2022
@eh-am eh-am deleted the chore/add-pyroscope-logo branch February 15, 2022 15:20
korniltsev pushed a commit that referenced this pull request Jul 18, 2023
* Fix dlv for cross compiling

Also upgrades dlv version to the latest v1.21.0.

* Ensure dlv debug image still works on linux_amd64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants