-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: migrate tests to ginkgo v2 #845
Conversation
Codecov Report
@@ Coverage Diff @@
## main #845 +/- ##
==========================================
- Coverage 70.44% 67.45% -2.99%
==========================================
Files 71 81 +10
Lines 2523 2838 +315
Branches 458 545 +87
==========================================
+ Hits 1777 1914 +137
- Misses 718 896 +178
Partials 28 28
Continue to review full report at Codecov.
|
Thanks for your contribution @dhanusaputra! It seem tests are failing though, as some of them have not been migrated. |
. "github.com/onsi/gomega" | ||
"github.com/tommy351/goldga" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to remove this because this package still use v1, will lead to panic
onsi/ginkgo#875
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not great, but not a big deal in my opinion. What do you think @eh-am ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dhanusaputra Can you try this fork I just created? https://github.com/pyroscope-io/goldga I migrated goldga library to use ginkgo v2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for help
looks ok
* Fixes iterator At value re-used * make fmt
close #824