-
Notifications
You must be signed in to change notification settings - Fork 628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add basic context menu #460
Conversation
Codecov Report
@@ Coverage Diff @@
## main #460 +/- ##
==========================================
+ Coverage 51.57% 51.61% +0.04%
==========================================
Files 125 125
Lines 5734 5734
==========================================
+ Hits 2957 2959 +2
+ Misses 2488 2486 -2
Partials 289 289
Continue to review full report at Codecov.
|
ParametersDetails
Result
Details
Screenshots |
webapp/javascript/components/FlameGraph/FlameGraphComponent/ContextMenu.spec.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I think increasing the bar height is fine. This for a temporary time make languages with deep/high stacktraces a slightly worse experience. However, once we add the collapse feature I think this will be fixed.
…he-board Update go.mod dependencies
contexmenu
event, ie right click)Also increased the BAR_HEIGHT to make it easier to click.
We rely strictly on
contextmenu
event, which does not seem to work on IOS (https://webkit.org/b/213953)