-
Notifications
You must be signed in to change notification settings - Fork 687
Benchmark dashboard #349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benchmark dashboard #349
Conversation
@eh-am Looks good, I have 3 comments:
|
Codecov Report
@@ Coverage Diff @@
## main #349 +/- ##
=======================================
Coverage 54.32% 54.32%
=======================================
Files 102 102
Lines 5013 5013
=======================================
Hits 2723 2723
Misses 2041 2041
Partials 249 249 Continue to review full report at Codecov.
|
Done.
It's just an indication that the client has started, but yeah it's bit redundant given that we have the
Ah it's not that hacky, I think it works pretty well. Honestly there are many columns which don't work well with an horizontal table, and having a vertical table seems non trivial (grafana/grafana#36973). So I left as it it's. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Update deploy in Kubernetes guide
Creates a benchmark dashboard based on the user facing one.

The only difference so far is an additional row at the top with benchmark metrics:
Plus updates
examples/grafana-integration
, although it's not currently functional, since it refers to thepyroscope:latest
docker image, which doesn't contain the new metric names yet.