Skip to content

Conversation

yashsarma
Copy link
Contributor

Error: /etc/agent/config.river:61:47: field "targets" does not exist

60 |     forward_to = [pyroscope.write.endpoint.receiver]
61 |     targets = discovery.relabel.specific_pods.targets
   |                                               ^^^^^^^
62 | }

ts=2024-03-21T16:17:33.064918553Z level=error msg="failed to start reporter" err="context canceled"
interrupt received
Error: could not perform the initial load successfully

@yashsarma yashsarma requested a review from a team as a code owner March 21, 2024 18:36
@CLAassistant
Copy link

CLAassistant commented Mar 21, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ simonswine
❌ yashsarma
You have signed the CLA already but the status is still pending? Let us recheck it.

@knylander-grafana knylander-grafana added the type/docs Improvements for doc docs. Used by Docs team for project management label Mar 25, 2024
@knylander-grafana
Copy link
Contributor

Thank you for submitting a fix for the docs! I'm going to defer to someone who can verify your update to approve.

yashsarma and others added 2 commits March 27, 2024 13:18
Error: /etc/agent/config.river:61:47: field "targets" does not exist

60 |     forward_to = [pyroscope.write.endpoint.receiver]
61 |     targets = discovery.relabel.specific_pods.targets
   |                                               ^^^^^^^
62 | }
URL needs to be part of a endpoint structure.
Copy link
Contributor

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you @yashsarma for spotting the problem and fixing it. You just need to sign the CLA in order for us to merge the PR.

While testing your change I also noticed another problem, which I fixed in the same go.

@simonswine simonswine merged commit 9da955c into grafana:main Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Improvements for doc docs. Used by Docs team for project management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants