Introduce a meta fetcher that synchronize filtered metadata locally #2381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolesnikovae
approved these changes
Sep 11, 2023
Comment on lines
+226
to
+232
| // todo(cyriltovena): we should use ReaderWithExpectedErrs(f.bkt.IsObjNotFoundErr) here, to avoid counting IsObjNotFoundErr as an error | ||
| // since this is expected | ||
| r, err := f.bkt.Get(ctx, metaFile) | ||
| if f.bkt.IsObjNotFoundErr(err) { | ||
| // Meta.json was deleted between bkt.Exists and here. | ||
| return nil, errors.Wrapf(ErrorSyncMetaNotFound, "%v", err) | ||
| } |
There was a problem hiding this comment.
I guess it should be fine. The only caller is fetchMetadata which does handle ErrorSyncMetaNotFound error properly so we probably don't have to do anything special here
There was a problem hiding this comment.
Yeah the original code was doing this, mostly for metrics, which is not urgent, but I think I can roll it back I was able to make ReaderWithExpectedErrs work I think
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also introduces markers for deletions
Most of the code is adapted from Mimir.