-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Grafana flamegraph component #2346
Conversation
|
Added fixes for the units here. The css fixes need to be in flamegraph so have separate PR here grafana/grafana#75369. @Rperry2174 U think the percentages are just hidden because the view is too narrow and the table is then horizontally scrollable this is what I see: |
@Rperry2174 regarding the tooltip table, we have a bit weird styling there and it seems it hasn't it's own intrinsic size so best I can do right now is to make it's min width a bit bigger that way it should not squish text into 2 lines. |
@Rperry2174 updated the flamegraph version so things should be fixed now. This is for example how the wrong diff selection looks like, which is also how currently it works in pyroscope, also it shows change in the greyed out parts, some more spacing and background for table, also units should be correct now: ![]() |
72a054a
to
7198b47
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!!! Amazing 💯
Changes the flamegraph component to use the one from grafana:
![Screenshot 2023-09-20 at 15 17 36](https://private-user-images.githubusercontent.com/1014802/269317828-fd4c03ea-b9c2-472a-be6b-e2f437e56c7e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5NDI3NjksIm5iZiI6MTczODk0MjQ2OSwicGF0aCI6Ii8xMDE0ODAyLzI2OTMxNzgyOC1mZDRjMDNlYS1iOWMyLTQ3MmEtYmU2Yi1lMmY0MzdlNTZjN2UucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIwNyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMDdUMTUzNDI5WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NGUwZDYwNDFhYWRkZTk3Mzg5NWVhNmFlNmQ5YTEyMWYwMzE2ZjE3OGQyNmZiNDhhNTAyMjc4OTBjOTg4ZTQ4NiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.Sc0LQRVX6GziI7bSfpFnNOplvhHko9xZXX96fY6Cf98)
At this moment this still contains all the old flamegraph code and uses a switch in features.ts
isGrafanaFlamegraphEnabled
to enable one or the other.