Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Export to flamegraph.com #2018

Merged
merged 7 commits into from
Jul 19, 2023
Merged

Adds Export to flamegraph.com #2018

merged 7 commits into from
Jul 19, 2023

Conversation

cyriltovena
Copy link
Contributor

@cyriltovena cyriltovena commented Jul 19, 2023

Now that we have CORS setup on the flamegrah.com side, we can simply call the API from here.

I also merged improvement to use saveAs library

@CLAassistant
Copy link

CLAassistant commented Jul 19, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I have given that a try and it works for me

@cyriltovena
Copy link
Contributor Author

I'm adding more commit as I'm testing it in Grafana too :/

@cyriltovena cyriltovena merged commit 5f0bcc5 into next Jul 19, 2023
@cyriltovena cyriltovena deleted the feat/flamegraphcom branch July 19, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants