Skip to content

Conversation

@santihernandezc
Copy link

This PR makes it possible to store the last error for each receiver in case of notification delivery failure. These errors are exposed via the /api/v2/receivers endpoint.

@santihernandezc santihernandezc force-pushed the feature/errors-in-notifications branch from 2b95b71 to 42cc05b Compare January 19, 2023 17:21
This PR makes it possible to store the last error for each receiver in case of notification delivery failure. These errors are exposed via the `/api/v2/receivers` endpoint.
@santihernandezc santihernandezc force-pushed the feature/errors-in-notifications branch from 42cc05b to f58105d Compare January 19, 2023 17:43
@gotjosh gotjosh merged commit ec19b0a into main Jan 19, 2023
grobinson-grafana pushed a commit that referenced this pull request Apr 26, 2023
This PR makes it possible to store the last error for each receiver in case of notification delivery failure. These errors are exposed via the `/api/v2/receivers` endpoint.

Co-authored-by: gotjosh <josue.abreu@gmail.com>
grobinson-grafana added a commit that referenced this pull request Apr 26, 2023
Capture and expose notification delivery errors (#31)
JohnnyQQQQ pushed a commit that referenced this pull request May 8, 2023
This PR makes it possible to store the last error for each receiver in case of notification delivery failure. These errors are exposed via the `/api/v2/receivers` endpoint.

Co-authored-by: gotjosh <josue.abreu@gmail.com>
JohnnyQQQQ added a commit that referenced this pull request May 8, 2023
Capture and expose notification delivery errors (#31)
grobinson-grafana pushed a commit that referenced this pull request Aug 14, 2023
This PR makes it possible to store the last error for each receiver in case of notification delivery failure. These errors are exposed via the `/api/v2/receivers` endpoint.

Co-authored-by: gotjosh <josue.abreu@gmail.com>
grobinson-grafana pushed a commit that referenced this pull request Aug 14, 2023
This PR makes it possible to store the last error for each receiver in case of notification delivery failure. These errors are exposed via the `/api/v2/receivers` endpoint.

Co-authored-by: gotjosh <josue.abreu@gmail.com>
Signed-off-by: George Robinson <george.robinson@grafana.com>
grobinson-grafana added a commit that referenced this pull request Aug 14, 2023
…fications

Capture and expose notification delivery errors (#31)
grobinson-grafana pushed a commit that referenced this pull request Aug 25, 2023
This PR makes it possible to store the last error for each receiver in case of notification delivery failure. These errors are exposed via the `/api/v2/receivers` endpoint.

Co-authored-by: gotjosh <josue.abreu@gmail.com>
grobinson-grafana added a commit that referenced this pull request Aug 25, 2023
Capture and expose notification delivery errors (#31)
grobinson-grafana pushed a commit that referenced this pull request Sep 11, 2023
This PR makes it possible to store the last error for each receiver in case of notification delivery failure. These errors are exposed via the `/api/v2/receivers` endpoint.

Co-authored-by: gotjosh <josue.abreu@gmail.com>
grobinson-grafana added a commit that referenced this pull request Sep 18, 2023
Rebased main onto "Capture and expose notification delivery errors (#31)"
alexweav pushed a commit that referenced this pull request Oct 27, 2023
This PR makes it possible to store the last error for each receiver in case of notification delivery failure. These errors are exposed via the `/api/v2/receivers` endpoint.

Co-authored-by: gotjosh <josue.abreu@gmail.com>
grobinson-grafana pushed a commit that referenced this pull request Jan 15, 2024
This PR makes it possible to store the last error for each receiver in case of notification delivery failure. These errors are exposed via the `/api/v2/receivers` endpoint.

Co-authored-by: gotjosh <josue.abreu@gmail.com>
grobinson-grafana pushed a commit that referenced this pull request Jan 26, 2024
This PR makes it possible to store the last error for each receiver in case of notification delivery failure. These errors are exposed via the `/api/v2/receivers` endpoint.

Co-authored-by: gotjosh <josue.abreu@gmail.com>
grobinson-grafana pushed a commit that referenced this pull request Jan 26, 2024
This PR makes it possible to store the last error for each receiver in case of notification delivery failure. These errors are exposed via the `/api/v2/receivers` endpoint.

Co-authored-by: gotjosh <josue.abreu@gmail.com>
grobinson-grafana pushed a commit that referenced this pull request Jan 26, 2024
This PR makes it possible to store the last error for each receiver in case of notification delivery failure. These errors are exposed via the `/api/v2/receivers` endpoint.

Co-authored-by: gotjosh <josue.abreu@gmail.com>
grobinson-grafana pushed a commit that referenced this pull request Jan 29, 2024
This PR makes it possible to store the last error for each receiver in case of notification delivery failure. These errors are exposed via the `/api/v2/receivers` endpoint.

Co-authored-by: gotjosh <josue.abreu@gmail.com>
grobinson-grafana pushed a commit that referenced this pull request Jan 30, 2024
This PR makes it possible to store the last error for each receiver in case of notification delivery failure. These errors are exposed via the `/api/v2/receivers` endpoint.

Co-authored-by: gotjosh <josue.abreu@gmail.com>
grobinson-grafana pushed a commit that referenced this pull request Feb 8, 2024
This PR makes it possible to store the last error for each receiver in case of notification delivery failure. These errors are exposed via the `/api/v2/receivers` endpoint.

Co-authored-by: gotjosh <josue.abreu@gmail.com>
grobinson-grafana pushed a commit that referenced this pull request Feb 14, 2024
This PR makes it possible to store the last error for each receiver in case of notification delivery failure. These errors are exposed via the `/api/v2/receivers` endpoint.

Co-authored-by: gotjosh <josue.abreu@gmail.com>
grobinson-grafana pushed a commit that referenced this pull request Feb 14, 2024
This PR makes it possible to store the last error for each receiver in case of notification delivery failure. These errors are exposed via the `/api/v2/receivers` endpoint.

Co-authored-by: gotjosh <josue.abreu@gmail.com>
grobinson-grafana pushed a commit that referenced this pull request Apr 22, 2024
This PR makes it possible to store the last error for each receiver in case of notification delivery failure. These errors are exposed via the `/api/v2/receivers` endpoint.

Co-authored-by: gotjosh <josue.abreu@gmail.com>
grobinson-grafana pushed a commit that referenced this pull request Apr 22, 2024
This PR makes it possible to store the last error for each receiver in case of notification delivery failure. These errors are exposed via the `/api/v2/receivers` endpoint.

Co-authored-by: gotjosh <josue.abreu@gmail.com>
grobinson-grafana pushed a commit that referenced this pull request Apr 22, 2024
This PR makes it possible to store the last error for each receiver in case of notification delivery failure. These errors are exposed via the `/api/v2/receivers` endpoint.

Co-authored-by: gotjosh <josue.abreu@gmail.com>
@diorcety
Copy link

diorcety commented May 16, 2024

There is an issue with this merge:

+                       if _, found := activeReceiversMap[rcv.Name]; !found {
                                // No need to build a receiver if no route is using it.
                                level.Info(configLogger).Log("msg", "skipping creation of receiver not referenced by any route", "receiver", rcv.Name)
+                               receivers = append(receivers, notify.NewReceiver(rcv.Name, false, nil))
                                continue
                        }
       "required": [
-        "name"
+        "name",
+        "active",
+        "integrations"
       ],

Either the required is incorrect (can't tell) or at couple of places there is missing code. For example if active/integrations are required, AlertToOpenAPIAlert should be fixed !

@santihernandezc what do you think?

yuri-tceretian pushed a commit that referenced this pull request Oct 15, 2025
This PR makes it possible to store the last error for each receiver in case of notification delivery failure. These errors are exposed via the `/api/v2/receivers` endpoint.

Co-authored-by: gotjosh <josue.abreu@gmail.com>

^ Conflicts:
^	cmd/alertmanager/main.go
^	config/receiver/receiver.go
^	notify/notify.go

^ Conflicts:
^	notify/notify.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants