Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix swc-core version to 1.3.75 to prevent existing bug with baseUrls #346

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

academo
Copy link
Member

@academo academo commented Aug 14, 2023

What this PR does / why we need it:

Fixes a reported issue where running build after running npm install or yarn install fails the build with error

panicked at 'base_dir(./src) must be absolute. Please ensure that jsc.baseUrl is specified correctly.'

The error is fixed by pinning the version of @swc/core to a known working version 1.3.75. while the proper fix swc-project/swc-node#721 is released .

Which issue(s) this PR fixes:

Fixes #344

Special notes for your reviewer:

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @grafana/create-plugin@1.10.1-canary.346.8316a63.0
# or 
yarn add @grafana/create-plugin@1.10.1-canary.346.8316a63.0

@academo academo self-assigned this Aug 14, 2023
@academo academo added create-plugin related to the create-plugin tool patch Increment the patch version when merged release Create a release when this pr is merged type/bug Something isn't working labels Aug 14, 2023
@academo academo merged commit 96fc643 into main Aug 14, 2023
2 checks passed
@academo academo deleted the academo/fix-swc-core-version branch August 14, 2023 09:00
@grafana-delivery-bot
Copy link

🚀 PR was released in @grafana/create-plugin@1.10.1 🚀

@grafana-delivery-bot grafana-delivery-bot bot added the released This issue/pull request has been released. label Aug 14, 2023
csmarchbanks added a commit to grafana/grafana-llm-app that referenced this pull request Sep 5, 2023
A bug was introduced into @swc/core which causes builds to fail. See
grafana/plugin-tools#346 for more information.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
create-plugin related to the create-plugin tool patch Increment the patch version when merged release Create a release when this pr is merged released This issue/pull request has been released. type/bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

Bug: everything fresh installed, yarn build doesnt work.
2 participants