Skip to content
This repository has been archived by the owner on Jul 19, 2023. It is now read-only.

Add store-gateway components #701

Merged
merged 52 commits into from
Jun 1, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
52 commits
Select commit Hold shift + click to select a range
d3f473d
WIP How to gather block metadata quickly from bucket
simonswine Feb 22, 2023
391a85a
Download metadata asynchronously
cyriltovena May 15, 2023
24cc7f5
Add Go module mimir/store-gateway dependency
cyriltovena May 16, 2023
776446c
Merge bucket listing branch
cyriltovena May 16, 2023
ffe1c80
Add store-gateway skeleton
cyriltovena May 16, 2023
eb17c54
Resolve conflicts in dependencies
cyriltovena May 16, 2023
babcfe0
Resolve lint issues
cyriltovena May 16, 2023
2f59938
Add users listing and fixes yaml dependency
cyriltovena May 16, 2023
ec177db
Fixes config files parsing and tsdb tests
cyriltovena May 16, 2023
d88fc0d
Hook into Pyroscope modules and disabled ip6
cyriltovena May 16, 2023
a9c545f
Fixes tenants listing
cyriltovena May 16, 2023
69de899
Adding initial code to list blocks
cyriltovena May 16, 2023
786c706
Implement the initial block listing without caching.
cyriltovena May 16, 2023
f465bb9
Speed up block listing
cyriltovena May 17, 2023
5c1f3a9
load from disk
cyriltovena May 17, 2023
e7c0016
Experiment with ristretto cache
cyriltovena May 17, 2023
d1f3cd4
fix block path
cyriltovena May 22, 2023
e9dd0bd
Revert dskit overrides now that the required update is merged
cyriltovena May 22, 2023
048acee
Merge remote-tracking branch 'origin/store-gateway-component' into st…
cyriltovena May 22, 2023
7926215
Fixes opening blocks from remote storage
cyriltovena May 22, 2023
0637dd1
Merge branch 'cache-store-gateway' into store-gateway-component
cyriltovena May 22, 2023
7ad32a0
Add the API skeleton for the storegateway
cyriltovena May 23, 2023
2b2e1a8
Implement the merge API in the query path
cyriltovena May 23, 2023
63d522a
Implement k-way merge of blocks and refactor sort iterator
cyriltovena May 23, 2023
2ef8e75
Refactor querier query replication
cyriltovena May 24, 2023
a9586a1
Initialize the store-gateway querier
cyriltovena May 25, 2023
738e295
Merge remote-tracking branch 'origin/main' into store-gateway-component
cyriltovena May 25, 2023
9f19111
Fixes the make generate target
cyriltovena May 25, 2023
e250daf
Merge commit '9f191111512ad0a7f45a042ca5d33dfe399bf2db' into store-ga…
cyriltovena May 25, 2023
b417de0
Regenerate docs
cyriltovena May 25, 2023
6f772fb
Fixes iterator tests
cyriltovena May 25, 2023
bb54d4d
Query the SelectMergeStacktraces API from Querier with store-gateway
cyriltovena May 25, 2023
189cf76
Fixes the store gateway querier initialization
cyriltovena May 26, 2023
aee9089
Fixes bucket sync on other providers
cyriltovena May 26, 2023
12a0986
Fixes wrong cancellation
cyriltovena May 26, 2023
91e53b2
Implement Select Series API
cyriltovena May 26, 2023
f02b165
Fixes lint issues.
cyriltovena May 27, 2023
4d17815
Merge remote-tracking branch 'origin/main' into store-gateway-component
cyriltovena May 30, 2023
cbfbb9d
Improve tracing instrumentation
cyriltovena May 30, 2023
b03dab8
generate help
cyriltovena May 30, 2023
1301f38
make fmt
cyriltovena May 30, 2023
23b896b
make helm
cyriltovena May 30, 2023
b7b32a0
Fixes deduplications in store-gateway
cyriltovena May 31, 2023
9c71811
Setting parquet read buffer size to 2MB
cyriltovena May 31, 2023
c4159ef
Merge remote-tracking branch 'origin/main' into store-gateway-component
cyriltovena May 31, 2023
4a3e4a6
make helm
cyriltovena May 31, 2023
888415b
Uses CloneVT from vtproto
cyriltovena May 31, 2023
355726b
Fixes objstore metrics
cyriltovena May 31, 2023
10649c3
make fmt
cyriltovena May 31, 2023
8e09dad
Fixes filesystem Bucket implementation
cyriltovena May 31, 2023
9036c3f
Merge remote-tracking branch 'origin/main' into store-gateway-component
cyriltovena Jun 1, 2023
a6bc302
Fixes the help text
cyriltovena Jun 1, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixes wrong cancellation
  • Loading branch information
cyriltovena committed May 26, 2023
commit 12a098690778f61e259c6fc7fbf005893e6f4e61
2 changes: 1 addition & 1 deletion pkg/phlare/phlare.go
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@ func (f *Phlare) setupModuleManager() error {
API: {Server},
Agent: {API},
Distributor: {Overrides, Ring, API, UsageReport},
Querier: {API, MemberlistKV, Ring, UsageReport},
Querier: {Overrides, API, MemberlistKV, Ring, UsageReport},
QueryFrontend: {OverridesExporter, API, MemberlistKV, UsageReport},
QueryScheduler: {Overrides, API, MemberlistKV, UsageReport},
Ingester: {Overrides, API, MemberlistKV, Storage, UsageReport},
Expand Down
3 changes: 2 additions & 1 deletion pkg/phlaredb/block_querier.go
Original file line number Diff line number Diff line change
Expand Up @@ -1105,7 +1105,8 @@ func (r *parquetReader[M, P]) open(ctx context.Context, bucketReader phlareobj.B
}
r.size = attrs.Size
}
ra, err := bucketReader.ReaderAt(ctx, filePath)
// the same reader is used to serve all requests, so we pass context.Background() here
ra, err := bucketReader.ReaderAt(context.Background(), filePath)
if err != nil {
return errors.Wrapf(err, "create reader '%s'", filePath)
}
Expand Down
214 changes: 0 additions & 214 deletions pkg/phlaredb/bucket/test.go

This file was deleted.

58 changes: 0 additions & 58 deletions pkg/phlaredb/bucket/test_test.go

This file was deleted.

6 changes: 3 additions & 3 deletions pkg/phlaredb/phlaredb.go
Original file line number Diff line number Diff line change
Expand Up @@ -252,19 +252,19 @@ func (f *PhlareDB) Series(ctx context.Context, req *connect.Request[ingestv1.Ser
func (f *PhlareDB) MergeProfilesStacktraces(ctx context.Context, stream *connect.BidiStream[ingestv1.MergeProfilesStacktracesRequest, ingestv1.MergeProfilesStacktracesResponse]) error {
f.headLock.RLock()
defer f.headLock.RUnlock()
return MergeProfilesStacktraces(ctx, stream, f.blockQuerier.Queriers().ForTimeRange)
return MergeProfilesStacktraces(ctx, stream, f.queriers().ForTimeRange)
}

func (f *PhlareDB) MergeProfilesLabels(ctx context.Context, stream *connect.BidiStream[ingestv1.MergeProfilesLabelsRequest, ingestv1.MergeProfilesLabelsResponse]) error {
f.headLock.RLock()
defer f.headLock.RUnlock()
return MergeProfilesLabels(ctx, stream, f.blockQuerier.Queriers().ForTimeRange)
return MergeProfilesLabels(ctx, stream, f.queriers().ForTimeRange)
}

func (f *PhlareDB) MergeProfilesPprof(ctx context.Context, stream *connect.BidiStream[ingestv1.MergeProfilesPprofRequest, ingestv1.MergeProfilesPprofResponse]) error {
f.headLock.RLock()
defer f.headLock.RUnlock()
return MergeProfilesPprof(ctx, stream, f.blockQuerier.Queriers().ForTimeRange)
return MergeProfilesPprof(ctx, stream, f.queriers().ForTimeRange)
}

type BidiServerMerge[Res any, Req any] interface {
Expand Down
1 change: 0 additions & 1 deletion pkg/phlaredb/query/iters.go
Original file line number Diff line number Diff line change
Expand Up @@ -933,7 +933,6 @@ func (r *RowNumberIterator[T]) Err() error {

func (r *RowNumberIterator[T]) Seek(to RowNumberWithDefinitionLevel) bool {
for CompareRowNumbers(0, r.current.RowNumber, to.RowNumber) == -1 {

if !r.Next() {
return false
}
Expand Down
Loading