Skip to content
This repository has been archived by the owner on Jul 19, 2023. It is now read-only.

Add help text test #539

Merged
merged 3 commits into from
Feb 24, 2023
Merged

Conversation

Rustin170506
Copy link
Contributor

@@ -72,7 +137,6 @@ func testSingle(t *testing.T, arguments []string, stdoutMessage, stderrMessage,
os.Args = oldArgs
restored = true
}
defer restoreIfNeeded()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can safely remove this. Because we already can it below.

@Rustin170506 Rustin170506 marked this pull request as draft February 22, 2023 14:33
@Rustin170506 Rustin170506 marked this pull request as ready for review February 23, 2023 12:53
@Rustin170506
Copy link
Contributor Author

@simonswine Could you please take a look? Thanks!

Copy link
Collaborator

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

That's a great way seeing changes to the help texts.

@simonswine simonswine merged commit f5802fb into grafana:main Feb 24, 2023
simonswine pushed a commit to simonswine/pyroscope that referenced this pull request Jun 30, 2023
* Add help text test

* Fix host

* Fix host
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants