Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ingest: add long polling to TestConcurrentFetchers #9971

Merged
merged 6 commits into from
Nov 21, 2024
Merged

ingest: add long polling to TestConcurrentFetchers #9971

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b6d78d4
ingest: add long polling to TestConcurrentFetchers
dimitarvdimitrov Nov 21, 2024
56367e7
Undo testing logger
dimitarvdimitrov Nov 21, 2024
ce89479
Add 2s to remaining places
dimitarvdimitrov Nov 21, 2024
3e848c1
Use testing logger
dimitarvdimitrov Nov 21, 2024
43c9edd
Don't immediately abort test when there are some buffered records
dimitarvdimitrov Nov 21, 2024
e1180c1
Increase timeout
dimitarvdimitrov Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use testing logger 
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
  • Loading branch information
@dimitarvdimitrov
dimitarvdimitrov committed Nov 21, 2024
commit 3e848c10008c9731fc14a37b9060cee3468fafd4
2 changes: 1 addition & 1 deletion pkg/storage/ingest/fetcher_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1331,7 +1331,7 @@ func TestFetchResult_Merge(t *testing.T) {
}

func createConcurrentFetchers(ctx context.Context, t *testing.T, client *kgo.Client, topic string, partition int32, startOffset int64, concurrency int, maxInflightBytes int32) *concurrentFetchers {
logger := log.NewNopLogger()
logger := testingLogger.WithT(t)

reg := prometheus.NewPedanticRegistry()
metrics := newReaderMetrics(partition, reg, noopReaderMetricsSource{})
Expand Down
Loading