Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR adds a hpa resource to the
ingester
component in themimir-distributed
helm chart.As the scaling down process is quite tricky as if not done properly, this could come with the loss of the data stored on the disk os the scaled down replica. To avoid that, the ingester's scaled down replica must be able to flush its data to the object storage before getting terminated. To achieve this, I looked at the PR that introduced hpa for loki components here.
I'm not sure whether the path for the added lifecycle is correct so please feel free to update it if that's the case.
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.