-
Notifications
You must be signed in to change notification settings - Fork 594
mimir: Inject span profiler into tracer #7363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we are missing assigning global tracer with the wrapped tracer again opentracing.SetGlobalTracer(wrappedTracer) so that opentracing.StartSpan is going to use the wrapped spanprofiler tracer whenever start a new span. as in the doc https://github.com/grafana/mimir/pull/7363/files#diff-1229eeb4fc2584d9d38b29af0cb7d1170ecbfa94a97923d265f227d6038ba845R33
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. I didn't release we're using both opentracing and opentelemetry, thank you 🆙