-
Notifications
You must be signed in to change notification settings - Fork 592
Helm: add ruler specific service account #7132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dimitarvdimitrov
merged 15 commits into
grafana:main
from
QuantumEnigmaa:add-ruler-specific-sa
Feb 8, 2024
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
ac43977
Helm: add ruler specific service account
QuantumEnigmaa 7823f5f
merge with main
QuantumEnigmaa 1ff829a
merge with main
QuantumEnigmaa 2d9ebc8
Merge branch 'main' of github.com:QuantumEnigmaa/mimir into add-ruler…
QuantumEnigmaa 0a40767
add suggestions from review
QuantumEnigmaa 9cca989
disable ruler sa by default
QuantumEnigmaa 05ae448
add rolebinding to ruler sa
QuantumEnigmaa abd5693
merge with main
QuantumEnigmaa caf8651
remove trailing space
QuantumEnigmaa 8b3bddd
update handling of ruler sa name
QuantumEnigmaa 220f2b6
Merge branch 'main' of github.com:QuantumEnigmaa/mimir into add-ruler…
QuantumEnigmaa 562f377
Merge branch 'main' of github.com:QuantumEnigmaa/mimir into add-ruler…
QuantumEnigmaa fd20ae2
Merge branch 'main' of github.com:QuantumEnigmaa/mimir into add-ruler…
QuantumEnigmaa 28423db
add doc comment for ruler sa name
QuantumEnigmaa e9d3c75
Merge branch 'main' of github.com:QuantumEnigmaa/mimir into add-ruler…
QuantumEnigmaa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 14 additions & 0 deletions
14
operations/helm/charts/mimir-distributed/templates/ruler/ruler-sa.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
{{- if .Values.ruler.serviceAccount.create }} | ||
apiVersion: v1 | ||
kind: ServiceAccount | ||
metadata: | ||
name: {{ template "mimir.ruler.serviceAccountName" . }} | ||
labels: | ||
{{- include "mimir.labels" (dict "ctx" .) | nindent 4 }} | ||
{{- with .Values.ruler.serviceAccount.labels }} | ||
{{- toYaml . | nindent 4 }} | ||
{{- end }} | ||
annotations: | ||
{{- toYaml .Values.ruler.serviceAccount.annotations | nindent 4 }} | ||
namespace: {{ .Release.Namespace | quote }} | ||
{{- end }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1114,6 +1114,17 @@ ruler: | |
annotations: {} | ||
labels: {} | ||
|
||
# -- Dedicated service account for ruler pods. | ||
# If not set, the default service account defined at the begining of this file will be used. | ||
# This service account can be used even if the default one is not set. | ||
serviceAccount: | ||
create: false | ||
# -- Ruler specific service account name. If not set and create is set to true, the default | ||
# name will be the default mimir service account's name with the "-ruler" suffix. | ||
name: "" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can you add a doc comment ( There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done :) |
||
annotations: {} | ||
labels: {} | ||
|
||
resources: | ||
requests: | ||
cpu: 100m | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.