Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace person with team for documentation reviews #3420

Merged
merged 2 commits into from
Nov 9, 2022

Conversation

osg-grafana
Copy link
Contributor

No description provided.

@osg-grafana osg-grafana added the type/docs Improvements or additions to documentation label Nov 9, 2022
@osg-grafana osg-grafana self-assigned this Nov 9, 2022
@osg-grafana osg-grafana requested a review from a team as a code owner November 9, 2022 11:40
@replay
Copy link
Contributor

replay commented Nov 9, 2022

Sorry, I approved a bit too quick, there is an error actually because this team docs-metrics is unknown. Should this be docs-squad?

@osg-grafana
Copy link
Contributor Author

Sorry, I approved a bit too quick, there is an error actually because this team docs-metrics is unknown. Should this be docs-squad?

See https://github.com/grafana/technical-documentation/issues/520

@@ -2,4 +2,4 @@
* @grafana/mimir-maintainers

# Documentation.
/docs/ @docs-metrics @grafana/mimir-maintainers
/docs/ @grafana/docs-metrics @grafana/mimir-maintainers
Copy link
Contributor Author

@osg-grafana osg-grafana Nov 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@replay, I am not sure what is accurate here:

  • @grafana/docs-metrics
  • @docs-metrics

Do I need to include the GitHub org? Ursula starts to Google...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, but I noticed that in the project settings page under "collaborators and teams" I see docs-squad but I don't see docs-metrics

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@osg-grafana osg-grafana Nov 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, but I noticed that in the project settings page under "collaborators and teams" I see docs-squad but I don't see docs-metrics

I dug around and created the new subteam, which right now only has me in it. :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I then added the team, and added write permissions. The CODEOWNERS file is now valid.

@osg-grafana osg-grafana changed the title Replace person with team for docs reviews Replace person with team for documentation reviews Nov 9, 2022
@osg-grafana osg-grafana merged commit fb27a7d into main Nov 9, 2022
@osg-grafana osg-grafana deleted the osg-grafana-patch-1 branch November 9, 2022 12:21
masonmei pushed a commit to udmire/mimir that referenced this pull request Dec 16, 2022
* Replace person with team for docs reviews; see (internal) https://github.com/grafana/technical-documentation/issues/520.

1. Remove `Docs Squad`.
2. Create team `grafana/docs-metrics`.
3. Add team members; right now it is just the default (me).
4. Add `grafana/docs-metrics` to the list of collaborators.
5. Select `Write` permissions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants