-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace person with team for documentation reviews #3420
Conversation
Sorry, I approved a bit too quick, there is an error actually because this team |
See https://github.com/grafana/technical-documentation/issues/520 |
@@ -2,4 +2,4 @@ | |||
* @grafana/mimir-maintainers | |||
|
|||
# Documentation. | |||
/docs/ @docs-metrics @grafana/mimir-maintainers | |||
/docs/ @grafana/docs-metrics @grafana/mimir-maintainers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@replay, I am not sure what is accurate here:
@grafana/docs-metrics
@docs-metrics
Do I need to include the GitHub org? Ursula starts to Google...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure, but I noticed that in the project settings page under "collaborators and teams" I see docs-squad
but I don't see docs-metrics
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure, but I noticed that in the project settings page under "collaborators and teams" I see
docs-squad
but I don't seedocs-metrics
I dug around and created the new subteam, which right now only has me in it. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I then added the team, and added write permissions. The CODEOWNERS
file is now valid.
* Replace person with team for docs reviews; see (internal) https://github.com/grafana/technical-documentation/issues/520. 1. Remove `Docs Squad`. 2. Create team `grafana/docs-metrics`. 3. Add team members; right now it is just the default (me). 4. Add `grafana/docs-metrics` to the list of collaborators. 5. Select `Write` permissions.
No description provided.