Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dashboards: add k8s resource requests to CPU and memory panels #2346

Merged
merged 1 commit into from
Jul 8, 2022

Conversation

bboreham
Copy link
Contributor

@bboreham bboreham commented Jul 8, 2022

What this PR does

This lets administrators see at a glance if requests are too low, which risks overloading nodes, or too high which wastes provisioning.

Example:
image

Checklist

  • NA Tests updated
  • Documentation added ? do we have docs for dashboards?
  • CHANGELOG.md updated

@CLAassistant
Copy link

CLAassistant commented Jul 8, 2022

CLA assistant check
All committers have signed the CLA.

This lets administrators see at a glance if requests are too low, which
risks overloading nodes, or too high which wastes provisioning.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
@bboreham bboreham force-pushed the dashboards-add-requests branch from bb5c49b to 17c76c6 Compare July 8, 2022 10:28
Copy link
Contributor

@treid314 treid314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Very helpful!

Copy link
Contributor

@56quarters 56quarters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@pracucci pracucci merged commit 6a3197c into main Jul 8, 2022
@pracucci pracucci deleted the dashboards-add-requests branch July 8, 2022 16:19
masonmei pushed a commit to udmire/mimir that referenced this pull request Jul 11, 2022
…na#2346)

This lets administrators see at a glance if requests are too low, which
risks overloading nodes, or too high which wastes provisioning.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants